Re: [[PATCH v2 2/2] OPP: Add 'opp-microwatt' parsing for advanced EM registration

From: Lukasz Luba
Date: Wed Feb 23 2022 - 04:13:19 EST




On 2/23/22 09:10, Viresh Kumar wrote:
On 23-02-22, 08:59, Lukasz Luba wrote:
OK, so you want to have this available for the whole system. I can do
that. I would go for one value of power

One value per supply, right ?

yes, only the u_watt, no _min, _max variants.


and try to fit into the
opp_parse_supplies() code.

Correct.

As far as I can see in the
dev_pm_opp_get_voltage() the simple solution: supplier[0] and u_volt
is used. I would go for similar solution for u_watt.
There is even a single u_amp and no _max, _min variants, so should be
good..

Yes, I don't think we need min/max/target kind of naming here. Just a single
value per supply is enough.


Good, thanks for comments. Let me craft the v3 then.