Re: [PATCH v6 5/7] pinctrl: qcom: Extract chip specific LPASS LPI code

[Srinivasa Rao Mandadapu]

On 2/20/2022 12:02 AM, Srinivasa Rao Mandadapu (Temp) wrote:
> On 2/19/2022 8:13 AM, Stephen Boyd wrote:
> Thanks for Your time Stephen!!!
> > Quoting Srinivasa Rao Mandadapu (2022-02-14 07:19:52)
> > > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c 
> > > b/drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c
> > > new file mode 100644
> > > index 0000000..27e358e
> > > --- /dev/null
> > > +++ b/drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c
> > > @@ -0,0 +1,166 @@
> > > +// SPDX-License-Identifier: GPL-2.0-only
> > > +/*
> > > + * Copyright (c) 2016-2019, The Linux Foundation. All rights reserved.
> > > + * Copyright (c) 2020 Linaro Ltd.
> > > + */
> > > +
> > > +#include <linux/clk.h>
> > > +#include <linux/gpio/driver.h>
> > > +#include <linux/module.h>
> > > +#include <linux/platform_device.h>
> > > +
> > > +#include "pinctrl-lpass-lpi.h"
> > Please include ../core.h here as well for the pin_group definition.
> Okay. will add it.

Actually, core.h was included in pinctrl-lpass-lpi.h. Including again 
here giving redefinition errors.

Already sent V8 with this change. will revert it and post again in v9.