Re: [PATCH] drm/bridge: ti-sn65dsi86: Properly undo autosuspend

From: Linus Walleij
Date: Tue Feb 22 2022 - 17:45:10 EST


On Tue, Feb 22, 2022 at 11:19 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> The PM Runtime docs say:
> Drivers in ->remove() callback should undo the runtime PM changes done
> in ->probe(). Usually this means calling pm_runtime_disable(),
> pm_runtime_dont_use_autosuspend() etc.
>
> We weren't doing that for autosuspend. Let's do it.
>
> Fixes: 9bede63127c6 ("drm/bridge: ti-sn65dsi86: Use pm_runtime autosuspend")
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Hm. I know a few places in drivers where I don't do this :/
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij