Re: [PATCH 29/49] memstick: replace bitmap_weight with bitmap_weight_eq where appropriate

From: Ulf Hansson
Date: Tue Feb 22 2022 - 10:49:48 EST


On Thu, 17 Feb 2022 at 17:55, Yury Norov <yury.norov@xxxxxxxxx> wrote:
>
> On Thu, Feb 17, 2022 at 7:39 AM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> >
> > On Fri, 11 Feb 2022 at 00:55, Yury Norov <yury.norov@xxxxxxxxx> wrote:
> > >
> > > msb_validate_used_block_bitmap() calls bitmap_weight() to compare the
> > > weight of bitmap with a given number. We can do it more efficiently with
> > > bitmap_weight_eq because conditional bitmap_weight may stop traversing the
> > > bitmap earlier, as soon as condition is (or can't be) met.
> > >
> > > Signed-off-by: Yury Norov <yury.norov@xxxxxxxxx>
> > > Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> > > Acked-by: Shubhankar Kuranagatti <shubhankar.vk@xxxxxxxxx>
> >
> > Applied for next, thanks!
>
> Hi Ulf,
>
> This patch depends on patch 26/49 "bitmap: add bitmap_weight_{cmp, eq,
> gt, ge, lt, le} functions"
> from this series. Can you make sure you applied them together? Or I can
> apply it later.

I can't apply them, unless there is an immutable branch being shared
between the different trees.

Therefore I have dropped the patch for now.

Kind regards
Uffe