Re: [PATCH -next v2] block: update io_ticks when io hang

From: Jens Axboe
Date: Tue Feb 22 2022 - 08:59:40 EST


On Thu, 17 Feb 2022 14:42:47 +0800, Zhang Wensheng wrote:
> When the inflight IOs are slow and no new IOs are issued, we expect
> iostat could manifest the IO hang problem. However after
> commit 5b18b5a73760 ("block: delete part_round_stats and switch to less
> precise counting"), io_tick and time_in_queue will not be updated until
> the end of IO, and the avgqu-sz and %util columns of iostat will be zero.
>
> Because it has using stat.nsecs accumulation to express time_in_queue
> which is not suitable to change, and may %util will express the status
> better when io hang occur. To fix io_ticks, we use update_io_ticks and
> inflight to update io_ticks when diskstats_show and part_stat_show
> been called.
>
> [...]

Applied, thanks!

[1/1] block: update io_ticks when io hang
commit: 86d7331299fda7634b11c1b7c911432679d525a5

Best regards,
--
Jens Axboe