Re: [RFT PATCH 0/3] Fix kfree() of const memory on setting driver_override

From: Rasmus Villemoes
Date: Tue Feb 22 2022 - 08:52:08 EST


On 22/02/2022 14.27, Krzysztof Kozlowski wrote:
> Hi,
>
> Drivers still seem to use driver_override incorrectly. Perhaps my old
> patch makes sense now?
> https://lore.kernel.org/all/1550484960-2392-3-git-send-email-krzk@xxxxxxxxxx/
>
> Not tested - please review and test (e.g. by writing to dirver_override
> sysfs entry with KASAN enabled).

Perhaps it would make sense to update the core code to release using
kfree_const(), allowing drivers to set the initial value with
kstrdup_const(). Drivers that currently use kstrdup() or kasprintf()
will continue to work [but if they kstrdup() a string literal they could
be changed to use kstrdup_const].

Rasmus