Re: [PATCH v9 02/10] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards

[Krzysztof Kozlowski]

On 22/02/2022 07:15, qinjian[覃健] wrote:
>>> +
>>> +properties:
>>> +  $nodename:
>>> +    const: '/'
>>> +  compatible:
>>> +    oneOf:
>>> +      - items:
>>> +          - const: sunplus,sp7021-achip
>>> +
>>
>> You did not publish DTS so bigger picture and context are missing here.
>> Is it a SoC compatible? A board compatible? Why only one? Against what
>> does it validate?
>>
>> This binding looks incomplete.
> 
> Sunplus SP7021 is an ARM Cortex A7 based SoC.
> The patch is for SP7021 SoC and SP7021 based boards.
> Sorry, I don't understand your questions.
> Could you explain more?

You have there only one compatible but if I would expect at least two.
One for SoC and one for board. Something like this:
Documentation/devicetree/bindings/arm/rda.yaml
but in your case enum would have only one entry.


Best regards,
Krzysztof