Re: [PATCH] mmc: rtsx: add 74 Clocks in power on flow

[gregkh@xxxxxxxxxxxxxxxxxxx]

On Tue, Feb 22, 2022 at 07:27:52AM +0000, Ricky WU wrote:
> After 1ms stabilizing the voltage time
> add "Host provides at least 74 Clocks
> before issuing first command" that is
> spec definition

You do have 72 columns to use here, no need to wrap this so tightly.

> 
> Signed-off-by: Ricky Wu <ricky_wu@xxxxxxxxxxx>
> ---
>  drivers/mmc/host/rtsx_pci_sdmmc.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c
> index 2a3f14afe9f8..e016d720e453 100644
> --- a/drivers/mmc/host/rtsx_pci_sdmmc.c
> +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
> @@ -940,10 +940,17 @@ static int sd_power_on(struct realtek_pci_sdmmc *host)
>  	if (err < 0)
>  		return err;
>  
> +	mdelay(1);

What is this delay for?

thanks,

greg k-h