Re: [PATCH net-next 3/3] net: neigh: add skb drop reasons to arp_error_report()

From: David Ahern
Date: Mon Feb 21 2022 - 22:19:33 EST


On 2/20/22 8:57 AM, menglong8.dong@xxxxxxxxx wrote:
> From: Menglong Dong <imagedong@xxxxxxxxxxx>
>
> When neighbour become invalid or destroyed, neigh_invalidate() will be
> called. neigh->ops->error_report() will be called if the neighbour's
> state is NUD_FAILED, and seems here is the only use of error_report().
> So we can tell that the reason of skb drops in arp_error_report() is
> SKB_DROP_REASON_NEIGH_FAILED.
>
> Replace kfree_skb() used in arp_error_report() with kfree_skb_reason().
>
> Reviewed-by: Mengen Sun <mengensun@xxxxxxxxxxx>
> Reviewed-by: Hao Peng <flyingpeng@xxxxxxxxxxx>
> Signed-off-by: Menglong Dong <imagedong@xxxxxxxxxxx>
> ---
> net/ipv4/arp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@xxxxxxxxxx>