Re: [PATCHv3 02/32] x86/coco: Add API to handle encryption mask

From: Kirill A. Shutemov
Date: Mon Feb 21 2022 - 18:19:31 EST


On Mon, Feb 21, 2022 at 11:56:00PM +0100, Borislav Petkov wrote:
> On Tue, Feb 22, 2022 at 01:21:49AM +0300, Kirill A. Shutemov wrote:
> > Well, it actually going to be
> >
> > cpa.mask_set = enc ? cc_mkenc(__pgprot(0)) : cc_mkdec(__pgprot(0));
> > cpa.mask_clr = enc ? cc_mkdec(__pgprot(0)) : cc_mkenc(__pgprot(0));
> >
> > as '0' is not a valid pgprot_t.
> >
> > Still wonna go this path?
>
> Why "still"? What's wrong with that?

IMO, it makes these statement substantially uglier.

--
Kirill A. Shutemov