Re: [PATCH net] net: dsa: fix panic when removing unoffloaded port from bridge

From: Vladimir Oltean
Date: Mon Feb 21 2022 - 15:46:04 EST


On Mon, Feb 21, 2022 at 08:38:21PM +0000, Alvin Šipraga wrote:
> >> + info.bridge = *dp->bridge,
> >
> > By the way, does this patch compile, with the comma and not the
> > semicolon, like that?
>
> Yikes, sorry about that. Sent a corrected v2 now.
>
> It does actually compile though.

Yes, I see, I think it probably works too:

info.bridge = *dp->bridge, dsa_port_bridge_destroy(dp, br);

although I would never write code like that.