Re: [PATCH v4 2/3] dt-bindings:iio:amplifiers: add ada4250 doc

From: Krzysztof Kozlowski
Date: Mon Feb 21 2022 - 11:35:53 EST


On 21/02/2022 10:27, Antoniu Miclaus wrote:
> Add device tree bindings for the ADA4250 driver.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> ---
> changes in v4:
> - add `spi-max-frequency` property
> - use generic node naming
> .../bindings/iio/amplifiers/adi,ada4250.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
>

Please do not resend without fixing pointed out issues. It just looks
you ignore comments.

Please fix or respond to previous comments. Please also fix all common
issues recently pointed out for all Analog devices - folks from Analog
are making the same mistakes. Reviewing the same mistake is a bit a
waste of time. Much more appreciated is when team applies one feedback
to all its submissions. IOW, do not repeat the same mistake second time.


Best regards,
Krzysztof