Re: [PATCH v2 04/10] random: group initialization wait functions

[Jason A. Donenfeld]

On Mon, Feb 21, 2022 at 5:49 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> On Sat, Feb 12, 2022 at 01:23:12PM +0100, Jason A. Donenfeld wrote:
> > +/*
> > + * Static global variables
> > + */
> > +static DECLARE_WAIT_QUEUE_HEAD(random_write_wait);
> > +static struct fasync_struct *fasync;
> > +
> > +static int crng_init_cnt = 0;
> > +static void _get_random_bytes(void *buf, size_t nbytes);
>
> A couple oddities here:
>
>   - 'fasync' is being defined twice.  It's already defined earlier in the file.
>   - The prototype for _get_random_bytes() is unnecessary.
>
> Other than that this patch looks good.

Nice catch, thanks. Will fix.

Jason