Re: [PATCHv3 13/32] x86/tdx: Detect TDX at early kernel decompression time

From: Kirill A. Shutemov
Date: Mon Feb 21 2022 - 08:53:36 EST


On Mon, Feb 21, 2022 at 02:37:29PM +0300, Cyrill Gorcunov wrote:
> On Fri, Feb 18, 2022 at 07:16:59PM +0300, Kirill A. Shutemov wrote:
> ...
> >
> > +
> > +void early_tdx_detect(void)
> > +{
> > + u32 eax, sig[3];
> > +
> > + cpuid_count(TDX_CPUID_LEAF_ID, 0, &eax, &sig[0], &sig[2], &sig[1]);
> > +
> > + if (memcmp(TDX_IDENT, sig, 12))
> > + return;
>
> Maybe worth to guard ourself, like
>
> BUILD_BUG_ON(sizeof(sig) != (sizeof(TDX_IDENT)-1));
> if (memcmp(TDX_IDENT, sig, sizeof(sig))
> return;

Sure. Will do.

--
Kirill A. Shutemov