Re: [PATCH v3 3/9] gpu: host1x: Add context device management code

From: Mikko Perttunen
Date: Mon Feb 21 2022 - 06:38:16 EST


On 2/19/22 19:52, Dmitry Osipenko wrote:
18.02.2022 14:39, Mikko Perttunen пишет:
+ for (index = 0; index < cdl->len; index++) {
+ struct iommu_fwspec *fwspec;
+
+ ctx = &cdl->devs[index];
+
+ ctx->host = host1x;
+
+ device_initialize(&ctx->dev);
+
+ ctx->dev.dma_mask = &context_device_dma_mask;
+ ctx->dev.coherent_dma_mask = context_device_dma_mask;
+ dev_set_name(&ctx->dev, "host1x-ctx.%d", index);
+ ctx->dev.bus = &host1x_context_device_bus_type;

host1x_context_device_bus_type will be an undefined symbol if
CONFIG_TEGRA_HOST1X_CONTEXT_BUS=n? Please compile and test all combinations.

But this file is only built if CONFIG_HOST1X, which selects CONFIG_TEGRA_HOST1X_CONTEXT_BUS?

Mikko