Re: [PATCH 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings

From: Sandeep Maheswaram
Date: Mon Feb 21 2022 - 00:49:37 EST



On 2/16/2022 9:17 AM, Pavan Kondeti wrote:
On Tue, Feb 15, 2022 at 06:10:45PM -0800, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-02-15 11:55:18)
On 15/02/2022 22:19, Sandeep Maheswaram wrote:
Add support for overriding SNPS phy tuning parameters in device tree
bindings.
This does not really benefit the users and does not help developers.
Could you please change the dt bindings to specify values for
thresholds, durations, impedance, etc. The values should be represented
in the human units (e.g. us, Ohms, mV), not in the internal register
'bits' representation.
+1
Agreed to this proposal.

Sandeep,

We have a similar implemention in QUSB phy driver. can we have something like
that for SNPSHS PHY too?

Thanks,
Pavan
Okay. Will do in the next version.