Re: [PATCH v2 05/10] random: group crng functions

From: Eric Biggers
Date: Mon Feb 21 2022 - 00:00:56 EST


On Sat, Feb 12, 2022 at 01:23:13PM +0100, Jason A. Donenfeld wrote:
> - /* We copy the new key into the base_crng, overwriting the old one,
> + /*
> + * We copy the new key into the base_crng, overwriting the old one,
> * and update the generation counter. We avoid hitting ULONG_MAX,
> * because the per-cpu crngs are initialized to ULONG_MAX, so this
> * forces new CPUs that come online to always initialize.
> @@ -635,13 +472,11 @@ static void crng_reseed(void)

Overall looks good, but it's not ideal seeing comments reformatted like this
rather than doing them the right way from the beginning.

Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx>

- Eric