Re: [PATCH v8 2/3] MIPS: Loongson64: dts: update the display controller device node

From: Sui Jingfeng
Date: Sun Feb 20 2022 - 20:35:33 EST



On 2022/2/18 00:39, Rob Herring wrote:
On Thu, 17 Feb 2022 02:17:11 +0800, Sui Jingfeng wrote:
From: suijingfeng <suijingfeng@xxxxxxxxxxx>

The display controller is a pci device, its PCI vendor id is 0x0014
its PCI device id is 0x7a06.

1) In order to let the lsdc kms driver to know which chip the DC is
contained in, we add different compatible for different chip.

2) Add display controller device node for ls2k1000 SoC

Signed-off-by: suijingfeng <suijingfeng@xxxxxxxxxxx>
Signed-off-by: Sui Jingfeng <15330273260@xxxxxx>
---
.../loongson/loongson,display-controller.yaml | 114 ++++++++++++++++++
.../display/loongson/loongson-drm.txt | 16 +++
.../boot/dts/loongson/loongson64-2k1000.dtsi | 8 ++
arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 7 +-
4 files changed, 140 insertions(+), 5 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/loongson/loongson,display-controller.yaml
create mode 100644 Documentation/devicetree/bindings/display/loongson/loongson-drm.txt

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/display/loongson/loongson,display-controller.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/display/loongson/loongson,display-controller.yaml#
Error: Documentation/devicetree/bindings/display/loongson/loongson,display-controller.example.dts:22.30-31 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:378: Documentation/devicetree/bindings/display/loongson/loongson,display-controller.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1398: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1593886

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

Ok, I know that now, thank for you point it to me.