Re: [PATCH] ravb: Use GFP_KERNEL instead of GFP_ATOMIC when possible

[Sergey Shtylyov]

Hello!

On 2/20/22 10:27 AM, Christophe JAILLET wrote:

> 'max_rx_len' can be up to GBETH_RX_BUFF_MAX (i.e. 8192) (see
> 'gbeth_hw_info').
> The default value of 'num_rx_ring' can be BE_RX_RING_SIZE (i.e. 1024).
> 
> So this loop can allocate 8 Mo of memory.

   MB? :-)

> 
> Previous memory allocations in this function already use GFP_KERNEL, so
> use __netdev_alloc_skb() and an explicit GFP_KERNEL instead of a
> implicit GFP_ATOMIC.
> 
> This gives more opportunities of successful allocation.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>

[...]

MBR, Sergey