Re: [PATCH v2 3/3] net: tun: track dropped skb via kfree_skb_reason()

[Dongli Zhang]

Hi David,

On 2/19/22 2:54 PM, David Ahern wrote:
> On 2/19/22 12:12 PM, Dongli Zhang wrote:
>> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
>> index aa27268edc5f..ab47a66deb7f 100644
>> --- a/drivers/net/tun.c
>> +++ b/drivers/net/tun.c
>> @@ -1062,13 +1062,16 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, struct net_device *dev)
>>  	struct netdev_queue *queue;
>>  	struct tun_file *tfile;
>>  	int len = skb->len;
>> +	int drop_reason;
> 
> enum skb_drop_reason
> 

As mentioned in previous email ...

According to cscope, so far all 'drop_reason' are declared in type 'int' (e.g.,
ip_rcv_finish_core()).

I will change above to enum.

Thank you very much!

Dongli Zhang