Re: [PATCH v6 4/7] pinctrl: qcom: Update lpi pin group structure

[Srinivasa Rao Mandadapu (Temp)]

On 2/19/2022 8:08 AM, Stephen Boyd wrote:
Thanks for your time Stephen!!!
> Quoting Srinivasa Rao Mandadapu (2022-02-14 07:19:51)
> > @@ -150,20 +148,20 @@ enum sm8250_lpi_functions {
> >          LPI_MUX__,
> >   };
> >
> > -static const unsigned int gpio0_pins[] = { 0 };
> > -static const unsigned int gpio1_pins[] = { 1 };
> > -static const unsigned int gpio2_pins[] = { 2 };
> > -static const unsigned int gpio3_pins[] = { 3 };
> > -static const unsigned int gpio4_pins[] = { 4 };
> > -static const unsigned int gpio5_pins[] = { 5 };
> > -static const unsigned int gpio6_pins[] = { 6 };
> > -static const unsigned int gpio7_pins[] = { 7 };
> > -static const unsigned int gpio8_pins[] = { 8 };
> > -static const unsigned int gpio9_pins[] = { 9 };
> > -static const unsigned int gpio10_pins[] = { 10 };
> > -static const unsigned int gpio11_pins[] = { 11 };
> > -static const unsigned int gpio12_pins[] = { 12 };
> > -static const unsigned int gpio13_pins[] = { 13 };
> > +static int gpio0_pins[] = { 0 };
> Why do we lose const?
Const here is creating conflicts with gpio group_desc structure!!!
> > +static int gpio1_pins[] = { 1 };
> > +static int gpio2_pins[] = { 2 };
> > +static int gpio3_pins[] = { 3 };
> > +static int gpio4_pins[] = { 4 };
> > +static int gpio5_pins[] = { 5 };
> > +static int gpio6_pins[] = { 6 };
> > +static int gpio7_pins[] = { 7 };
> > +static int gpio8_pins[] = { 8 };
> > +static int gpio9_pins[] = { 9 };
> > +static int gpio10_pins[] = { 10 };
> > +static int gpio11_pins[] = { 11 };
> > +static int gpio12_pins[] = { 12 };
> > +static int gpio13_pins[] = { 13 };
> >   static const char * const swr_tx_clk_groups[] = { "gpio0" };
> >   static const char * const swr_tx_data_groups[] = { "gpio1", "gpio2", "gpio5" };
> >   static const char * const swr_rx_clk_groups[] = { "gpio3" };