Re: [BUG/PATCH v3] net: mvpp2: always set port pcs ops

[Jakub Kicinski]

On Sat, 19 Feb 2022 00:49:27 +0100 Marcin Wojtas wrote:
> wt., 15 lut 2022 o 00:18 Jeremy Linton <jeremy.linton@xxxxxxx> napisał(a):
> > Booting a MACCHIATObin with 5.17, the system OOPs with
> > a null pointer deref when the network is started. This
> > is caused by the pcs->ops structure being null in
> > mcpp2_acpi_start() when it tries to call pcs_config().
> >
> > Hoisting the code which sets pcs_gmac.ops and pcs_xlg.ops,
> > assuring they are always set, fixes the problem.

> > Fixes: cff056322372 ("net: mvpp2: use .mac_select_pcs() interface")
> > Suggested-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
> > Signed-off-by: Jeremy Linton <jeremy.linton@xxxxxxx>

> You can add my:
> Reviewed-by: Marcin Wojtas <mw@xxxxxxxxxxxx>

Perfect, thanks everyone! 

It's now 5a2aba71cd26 ("net: mvpp2: always set port pcs ops") in net.