Re: [PATCH v7 net-next] net-core: add InDropOtherhost counter

[Jeffrey Ji]

Hi Jakub, I'll remove the MIB counters & instead add counters to
rtnl_link_stats64 and rtnl_link_stats, does that sound right? But keep
the sbk_free_drop_reason


On Mon, Feb 7, 2022 at 7:51 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Mon,  7 Feb 2022 23:57:14 +0000 Jeffrey Ji wrote:
> > From: jeffreyji <jeffreyji@xxxxxxxxxx>
> >
> > Increment InDropOtherhost counter when packet dropped due to incorrect dest
> > MAC addr.
> >
> > An example when this drop can occur is when manually crafting raw
> > packets that will be consumed by a user space application via a tap
> > device. For testing purposes local traffic was generated using trafgen
> > for the client and netcat to start a server
> >
> > example output from nstat:
> > \~# nstat -a | grep InMac
> > Ip6InDropOtherhost                  0                  0.0
> > IpExtInDropOtherhost                1                  0.0
> >
> > Tested: Created 2 netns, sent 1 packet using trafgen from 1 to the other
> > with "{eth(daddr=$INCORRECT_MAC...}", verified that nstat showed the
> > counter was incremented.
>
> As far as I can tell nobody objected to my suggestion of making this
> a netdev counter, so please switch to working on that. Thanks.