Re: [tip:sched/core 27/28] kernel/sched/topology.c:2284:39: sparse: sparse: incorrect type in assignment (different address spaces)

From: K Prateek Nayak
Date: Fri Feb 18 2022 - 11:44:22 EST


Hello Mel,

On 2/17/2022 6:28 AM, kernel test robot wrote:
> [..snip..]
> 2282 /* Set span based on the first NUMA domain. */
> 2283 top = sd;
>> 2284 top_p = top->parent;
> 2285 while (top_p && !(top_p->flags & SD_NUMA)) {
>> 2286 top = top->parent;
> 2287 top_p = top->parent;
> 2288 }
> 2289 imb_span = top_p ? top_p->span_weight : sd->span_weight;

I was looking into this sparse warning when I noticed
that the variable "top" is actually redundant - "sd"
and "top_p" can suffice for the computation "top" is
involved in. I've created a patch to fix this warning
and remove the redundant variable top while at it.
https://lore.kernel.org/lkml/20220218162743.1134-1-kprateek.nayak@xxxxxxx/
--
Thanks and Regards,
Prateek