Re: [PATCH v4 1/2] dt-bindings: hwmon: add tmp464.yaml

[Guenter Roeck]

On 2/18/22 01:41, Agathe Porte wrote:
> Hi Guenter,
>
> Le 18/02/2022 à 07:58, Guenter Roeck a écrit :
> > From: Agathe Porte <agathe.porte@xxxxxxxxx>
> >
> > Add basic description of the tmp464 driver DT bindings.
> >
> > Signed-off-by: Agathe Porte <agathe.porte@xxxxxxxxx>
> > Cc: Krzysztof Adamski <krzysztof.adamski@xxxxxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> > v4:
> > - No changes
> >
> > +        channel@0 {
> > +          reg = <0x0>;
> > +          ti,n-factor = /bits/ 8 <(-10)>;
> > +          label = "local";
> > +        };
>
> Setting the n-factor for the local channel is not supported, so we should remove this attribute for this example and move it to another channel.

Done, thanks!

Guenter

> Here is the output on a hardware test:
>
> [165599.122883] tmp464 16-0049: n-factor can't be set for internal channel
> [165599.123833] tmp464: probe of 16-0049 failed with error -22
>
> > +
> > +        channel@1 {
> > +          reg = <0x1>;
> > +          ti,n-factor = /bits/ 8 <0x0>;
> > +          label = "somelabel";
> > +        };
> No particular issue when defining a property for channel that is not internal during driver probe.
> > +
> > +        channel@2 {
> > +          reg = <0x2>;
> > +          status = "disabled";
> > +        };
>
> Works as expected on target:
>
> root@fct-0a:/sys/class/hwmon/hwmon2 >cat temp3_input
> cat: temp3_input: No data available
>
> Best regards,
>
> Agathe.