RE: [PATCH v4 1/2] dt:bindings:iio:frequency: Add ADMV4420 doc

[Pop, Cristian]

> -----Original Message-----
> From: Jonathan Cameron <jic23@xxxxxxxxxx>
> Sent: Friday, February 18, 2022 2:04 PM
> To: Pop, Cristian <Cristian.Pop@xxxxxxxxxx>
> Cc: linux-iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx
> Subject: Re: [PATCH v4 1/2] dt:bindings:iio:frequency: Add ADMV4420 doc
> 
> [External]
> 
> On Fri, 18 Feb 2022 11:50:47 +0200
> Cristian Pop <cristian.pop@xxxxxxxxxx> wrote:
> 
> > Add device tree bindings for the ADMV4420 K band downconverter.
> >
> > Signed-off-by: Cristian Pop <cristian.pop@xxxxxxxxxx>
> > ---
> 
> Change log?  Also, looks like this crossed with a question from Rob on v3.
> 
In v3 there was a small change only, which I forgot to mention:
 - Add '$ref: /schemas/types.yaml#/definitions/uint32', for 'adi,lo-freq-khz'
Robs question on v3: '-khz is not a documented unit suffix. Does neither hz nor mhz not give enough resolution and range?'
The 32bit values in case we use ' -hz' property suffix, wont accommodate 17.5GHz for example.
For '-mhz' suffix, resolution is not good enough. 
I propose adding reference type '$ref: /schemas/types.yaml#/definitions/uint32' for '-khz' suffix.

> Thanks,
> 
> Jonathan
> 
> 
> >  .../bindings/iio/frequency/adi,admv4420.yaml  | 55
> > +++++++++++++++++++
> >  1 file changed, 55 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml
> > b/Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml
> > new file mode 100644
> > index 000000000000..35a3fb3fd339
> > --- /dev/null
> > +++
> b/Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yam
> > +++ l
> > @@ -0,0 +1,55 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> >
> +https://urldefense.com/v3/__http://devicetree.org/schemas/iio/frequen
> > +cy/adi,admv4420.yaml*__;Iw!!A3Ni8CS0y2Y!p1wBxz-
> QqJYCDNk3gYSMGaJoHbPGC
> > +RWOE04vh6kN2kHC84mPrBdIq_Pf1CgD3Z8knw$
> > +$schema:
> > +https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/core.y
> > +aml*__;Iw!!A3Ni8CS0y2Y!p1wBxz-
> QqJYCDNk3gYSMGaJoHbPGCRWOE04vh6kN2kHC84
> > +mPrBdIq_Pf1CiGygmUGw$
> > +
> > +title: ADMV4420 K Band Downconverter
> > +
> > +maintainers:
> > +  - Cristian Pop <cristian.pop@xxxxxxxxxx>
> > +
> > +description:
> > +  The ADMV4420 is a highly integrated, double balanced, active
> > +  mixer with an integrated fractional-N synthesizer, ideally suited
> > +  for next generation K band satellite communications
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,admv4420
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  spi-max-frequency:
> > +    maximum: 1000000
> > +
> > +  adi,lo-freq-khz:
> > +    description: LO Frequency
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +  adi,ref-ext-single-ended-en:
> > +    description: External reference selected.
> > +    type: boolean
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    spi {
> > +      #address-cells = <1>;
> > +      #size-cells = <0>;
> > +      admv4420@0 {
> > +        compatible = "adi,admv4420";
> > +        reg = <0>;
> > +        spi-max-frequency = <1000000>;
> > +        adi,lo-freq-khz = <16750000>;
> > +        adi,ref-ext-single-ended-en;
> > +      };
> > +    };
> > +...