RE: [Intel-wired-lan] [PATCH net-next 1/2] i40e: remove dead stores on XSK hotpath

[Kuruvinakunnel, George]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of Lobakin,
> Alexandr
> Sent: Wednesday, December 1, 2021 12:07 AM
> To: intel-wired-lan@xxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Jesper Dangaard Brouer <hawk@xxxxxxxxxx>;
> Daniel Borkmann <daniel@xxxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> bpf@xxxxxxxxxxxxxxx; John Fastabend <john.fastabend@xxxxxxxxx>; Alexei
> Starovoitov <ast@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Dumitrescu,
> Cristian <cristian.dumitrescu@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>;
> Karlsson, Magnus <magnus.karlsson@xxxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH net-next 1/2] i40e: remove dead stores on XSK
> hotpath
> 
> The 'if (ntu == rx_ring->count)' block in i40e_alloc_rx_buffers_zc() was previously
> residing in the loop, but after introducing the batched interface it is used only to wrap-
> around the NTU descriptor, thus no more need to assign 'xdp'.
> 
> 'cleaned_count' in i40e_clean_rx_irq_zc() was previously being incremented in the
> loop, but after commit f12738b6ec06
> ("i40e: remove unnecessary cleaned_count updates") it gets assigned only once after
> it, so the initialization can be dropped.
> 
> Fixes: 6aab0bb0c5cd ("i40e: Use the xsk batched rx allocation interface")
> Fixes: f12738b6ec06 ("i40e: remove unnecessary cleaned_count updates")
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@xxxxxxxxx>
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@xxxxxxxxx>