Re: [PATCH net-next 1/9] net: tcp: introduce tcp_drop_reason()

[Menglong Dong]

On Thu, Feb 17, 2022 at 12:50 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Wed, 16 Feb 2022 07:58:21 -0800
> Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> > On Wed, 16 Feb 2022 11:54:18 +0800 menglong8.dong@xxxxxxxxx wrote:
> > > +static inline void tcp_drop(struct sock *sk, struct sk_buff *skb)
> > > +{
> > > +   tcp_drop_reason(sk, skb, SKB_DROP_REASON_NOT_SPECIFIED);
> > >  }
> >
> > Please make this non-inline. The compiler will inline it anyway, and
> > if it's a static inline compiler will not warn us that it should be
> > removed once all callers are gone.
>
> I guess that's no longer true for C files.
>
>   https://lore.kernel.org/all/202202132037.4aN017dU-lkp@xxxxxxxxx/
>

Ok, seems we can keep this inline still.

> -- Steve