Re: [PATCH v2] clk: qcom: gcc-msm8994: Remove NoC clocks

[Konrad Dybcio]

On 18.02.2022 01:16, Stephen Boyd wrote:
> Quoting Konrad Dybcio (2022-02-17 15:24:08)
>> Just like in commit 05cf3ec00d460b50088d421fb878a0f83f57e262
>> ("clk: qcom: gcc-msm8996: Drop (again) gcc_aggre1_pnoc_ahb_clk")
>> adding NoC clocks turned out to be a huge mistake, as they cause a lot of
>> issues at little benefit (basically letting Linux know about their
>> children's frequencies), especially when mishandled or misconfigured.
>>
>> Adding these ones broke SDCC approx 99 out of 100 times, but that somehow
>> went unnoticed. To prevent further issues like this one, remove them.
>>
>> This commit is effectively a revert of 74a33fac3aab77558ca0d80c9935
>> (clk: qcom: gcc-msm8994: Add missing NoC clocks) with ABI preservation.
>>
>> Fixes: 74a33fac3aab ("clk: qcom: gcc-msm8994: Add missing NoC clocks")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
> 
> Is boot broken on msm8994? I can take this for clk-fixes then.

It technically boots, but depending on the board (different phones took this differently)
storage may or may not work.. So I guess picking it up in -fixes would be fair..

Konrad