Re: [PATCH v2 14/14] dt-bindings: rtc: pcf2127: add PCF2131

From: Rob Herring
Date: Thu Feb 17 2022 - 19:00:40 EST


On Fri, Feb 11, 2022 at 03:50:29PM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
>
> Add support for new NXP RTC PCF2131.
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> ---
> .../devicetree/bindings/rtc/nxp,pcf2127.yaml | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> index cde7b1675ead..57eb0a58afa3 100644
> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> @@ -14,7 +14,9 @@ maintainers:
>
> properties:
> compatible:
> - const: nxp,pcf2127
> + enum:
> + - nxp,pcf2127
> + - nxp,pcf2131
>
> reg:
> maxItems: 1
> @@ -48,4 +50,19 @@ examples:
> };
> };
>
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rtc@53 {
> + compatible = "nxp,pcf2131";
> + reg = <0x53>;
> + pinctrl-0 = <&rtc_nint_pins>;
> + interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;
> + reset-source;
> + };
> + };

Just a new compatible doesn't really justify another example.

Rob