Re: [PATCH v5 4/8] dt-bindings: firmware: arm,scmi: Add atomic-threshold-us optional property

From: Rob Herring
Date: Thu Feb 17 2022 - 16:35:03 EST


On Thu, Feb 17, 2022 at 7:13 AM Cristian Marussi
<cristian.marussi@xxxxxxx> wrote:
>
> SCMI protocols in the platform can optionally signal to the OSPM agent
> the expected execution latency for a specific resource/operation pair.
>
> Introduce an SCMI system wide optional property to describe a global time
> threshold which can be configured on a per-platform base to determine the
> opportunity, or not, for an SCMI command advertised to have a higher
> latency than the threshold, to be considered for atomic operations:
> high-latency SCMI synchronous commands should be preferably issued in the
> usual non-atomic mode.
>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: Cristian Marussi <cristian.marussi@xxxxxxx>
> ---
> v4 --> v5:
> - fixed example and removed dtschema warnings/errors :
> arm,scmi.yaml: properties:atomic-threshold-us:
> '$ref' should not be valid under {'const': '$ref'}

Seems an old version got picked up for linux-next:

/builds/robherring/linux-dt/Documentation/devicetree/bindings/firmware/arm,scmi.yaml:
properties:atomic-threshold-us: '$ref' should not be valid under
{'const': '$ref'}
hint: Standard unit suffix properties don't need a type $ref
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/linux-dt/Documentation/devicetree/bindings/firmware/arm,scmi.yaml:
ignoring, error in schema: properties: atomic-threshold-us

> - added default: 0 clause
> v3 --> v4
> - renamed property to atomic-threshold-us
> v1 --> v2
> - rephrased the property description
> ---
> .../devicetree/bindings/firmware/arm,scmi.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)

For this version:

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>