Re: [PATCH net-next v1] net: Use csum_replace_... and csum_sub() helpers instead of opencoding

From: Jakub Kicinski
Date: Thu Feb 17 2022 - 13:55:16 EST


On Thu, 17 Feb 2022 18:39:07 +0000 Christophe Leroy wrote:
> Le 17/02/2022 à 19:14, Jakub Kicinski a écrit :
> > On Thu, 17 Feb 2022 18:11:58 +0000 Christophe Leroy wrote:
> >> Looks like csum_replace4() expects __be32 inputs, I'll look at it but
> >> I'm not inclined at adding force cast, so will probably leave
> >> nft_csum_replace() as is.
> >
> > That may imply also leaving it in your tree..
>
> By "leave as is" I meant I'll drop the change.
>
> I'll send v2 without this hunk.

Thanks, sorry for the snarky comment, I read it as "take it or leave
it". I've heard too many of those lately.