Re: [PATCH v5 13/13] module: Move version support into a separate file

From: Miroslav Benes
Date: Thu Feb 17 2022 - 10:51:28 EST


> > > +struct symsearch {
> > > + const struct kernel_symbol *start, *stop;
> > > + const s32 *crcs;
> > > + enum mod_license {
> > > + NOT_GPL_ONLY,
> > > + GPL_ONLY,
> > > + } license;
> > > +};
> >
> > Why don't leave this in main.c ?
>
> Yes, struct 'symsearch' is not used outside of kernel/module/main.c.

It is not, but "struct find_symbol_arg", which you moved, uses "enum
mod_license" defined above, so you can either leave it as it is, or carve
"enum mod_license" definition out.

Miroslav