Re: [PATCH v2 02/15] staging: r8188eu: remove smaller sets of converted DBG_88E calls

[Dan Carpenter]

On Wed, Feb 16, 2022 at 12:42:57PM +0300, Pavel Skripkin wrote:
> > @@ -1467,15 +1447,6 @@ static int rtw_check_join_candidate(struct mlme_priv *pmlmepriv
> >   		updated = true;
> >   	}
> >   	if (updated) {
> > -		netdev_dbg(adapter->pnetdev,
> > -			   "[by_bssid:%u][assoc_ssid:%s]new candidate: %s(%pM rssi:%d\n",
> > -			   pmlmepriv->assoc_by_bssid,
> > -			   pmlmepriv->assoc_ssid.Ssid,
> > -			   (*candidate)->network.Ssid.Ssid,
> > -			   (*candidate)->network.MacAddress,
> > -			   (int)(*candidate)->network.Rssi);
> > -		netdev_dbg(adapter->pnetdev,
> > -			   "[to_roaming:%u]\n", rtw_to_roaming(adapter));
> >   	}
> 
> drop if

Yeah.  If you can drop the whole if statement then let's do that.

regards,
dan carpenter