Re: [PATCH] tps6598x: clear int mask on probe failure

[Greg Kroah-Hartman]

On Thu, Feb 17, 2022 at 06:51:27AM -0700, Jens Axboe wrote:
> On 2/17/22 1:30 AM, Heikki Krogerus wrote:
> > On Tue, Feb 15, 2022 at 11:22:04AM -0700, Jens Axboe wrote:
> >> The interrupt mask is enabled before any potential failure points in
> >> the driver, which can leave a failure path where we exit with
> >> interrupts enabled but the device not live. This causes an infinite
> >> stream of interrupts on an Apple M1 Pro laptop on USB-C.
> >>
> >> Add a failure label that's used post enabling interrupts, where we
> >> mask them again before returning an error.
> >>
> >> Suggested-by: Sven Peter <sven@xxxxxxxxxxxxx>
> >> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
> > 
> > Should this be marked as a fix?
> 
> Maybe, I can try and dig out the offending commit. From some quick
> checking, it didn't come in with recent fixes, so it's probably been
> there since support got added. Maybe we just mark it stable?
> 
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> 
> Thanks! Greg, will you pick this up?

Will do, thanks.

greg k-h