Re: [PATCH 1/2] thermal: cooling: Check Energy Model type in cpufreq_cooling and devfreq_cooling

From: Lukasz Luba
Date: Thu Feb 17 2022 - 07:37:22 EST




On 2/17/22 12:33 PM, Daniel Lezcano wrote:
On 17/02/2022 13:11, Lukasz Luba wrote:

[ ... ]

Why not make it more generic and replace the frequency by a performance index, so it can be used by any kind of perf limiter?

For that DT array, yes, it can be an index, so effectively it could be
a simple 1d array.

something like:

msm_gpu_energy_model: msm-gpu-energy-model {
     compatible = "energy-model"
     /* Values are sorted micro-Watts which correspond to each OPP
        or performance state. The total amount of them must match
        number of OPPs. */
     power-microwatt = <100000>,
             <230000>,
             <380000>,
             <600000>;
};

then in gpu node instead of having 'dynamic-power-coefficient',
which is useless because voltage is missing, we would have
'energy-model', like:

     energy-model = <&msm_gpu_energy_model>;


If you agree to continue this topic. I will send an RFC so we could
further discuss this idea. This $subject doesn't fit well.

Yes, definitively I agree to continue on this topic.



Great! I'm going to craft something...