Re: [PATCH 2 9/9] serial: atmel: remove redundant assignment in rs485_config

[Richard Genoud]

Le 16/02/2022 à 01:18, Lino Sanfilippo a écrit :
> In uart_set_rs485_config() the serial core already assigns the passed
> serial_rs485 struct to the uart port.
>
> So remove the assignment from the drivers rs485_config() function to avoid
> redundancy.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@xxxxxx>
Acked-by: Richard Genoud <richard.genoud@xxxxxxxxx>

> ---
>   drivers/tty/serial/atmel_serial.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 2d09a89974a2..2ab589a3d86c 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -299,11 +299,9 @@ static int atmel_config_rs485(struct uart_port *port,
>   	/* Resetting serial mode to RS232 (0x0) */
>   	mode &= ~ATMEL_US_USMODE;
>   
> -	port->rs485 = *rs485conf;
> -
>   	if (rs485conf->flags & SER_RS485_ENABLED) {
>   		dev_dbg(port->dev, "Setting UART to RS485\n");
> -		if (port->rs485.flags & SER_RS485_RX_DURING_TX)
> +		if (rs485conf->flags & SER_RS485_RX_DURING_TX)
>   			atmel_port->tx_done_mask = ATMEL_US_TXRDY;
>   		else
>   			atmel_port->tx_done_mask = ATMEL_US_TXEMPTY;

Thanks !