Re: [PATCH v3 1/4] Input: Extract ChromeOS vivaldi physmap show function

From: Stephen Boyd
Date: Wed Feb 16 2022 - 14:05:16 EST


Quoting Dmitry Torokhov (2022-02-15 21:36:09)
> On Thu, Feb 10, 2022 at 05:25:07PM -0800, Stephen Boyd wrote:
> > drivers/input/Kconfig | 7 +++++
> > drivers/input/Makefile | 1 +
> > drivers/input/keyboard/Kconfig | 2 ++
> > drivers/input/keyboard/atkbd.c | 22 +++++----------
> > drivers/input/keyboard/cros_ec_keyb.c | 32 ++++++++--------------
> > drivers/input/vivaldi-keymap.c | 39 +++++++++++++++++++++++++++
> > include/linux/input/vivaldi-keymap.h | 28 +++++++++++++++++++
>
> Since you called the config INPUT_VIVALDIFMAP I think we should call
> these files vivaldi-fmap.(h|c) as well. They are not really keymaps.

Sure. I used 'f' for 'function'. It could also be INPUT_VIVALDI_PHYSMAP
and vivaldi-physmap.(h|c) if that's more appropriate. I'll resend this
with fmap and we can take it from there.