Re: [PATCH] ACPICA: proactively check null ptr to avoid API misuse

From: Tong Zhang
Date: Wed Feb 16 2022 - 11:37:45 EST


On Wed, Feb 16, 2022 at 4:22 AM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
>
> On Wed, Feb 16, 2022 at 7:26 AM Tong Zhang <ztong0001@xxxxxxxxx> wrote:
> >
> > There are some cases that user use acpi_ns_walk_namespace() without
> > checking acpi_disable flag. When acpi=off is provided in boot cmdline,
> > acpi_gbl_root_node is NULL and calling acpi_ns_walk_namespace() will
> > crash kernel. In order to avoid such misuse, we proactively check null ptr
> > and return an error when we know ACPI is disabled.
>
> The issue should be fixed by this commit in the upstream ACPICA code
> base: https://github.com/acpica/acpica/commit/b1c3656ef4950098e530be68d4b589584f06cddc
>
Thank you Rafael. I've just seen that commit upstream.