Re: [PATCH net-next 1/9] net: tcp: introduce tcp_drop_reason()

From: Jakub Kicinski
Date: Wed Feb 16 2022 - 10:58:29 EST


On Wed, 16 Feb 2022 11:54:18 +0800 menglong8.dong@xxxxxxxxx wrote:
> +static inline void tcp_drop(struct sock *sk, struct sk_buff *skb)
> +{
> + tcp_drop_reason(sk, skb, SKB_DROP_REASON_NOT_SPECIFIED);
> }

Please make this non-inline. The compiler will inline it anyway, and
if it's a static inline compiler will not warn us that it should be
removed once all callers are gone.