Re: [PATCH v2 0/3] Magic Keyboard first generation and 2015 FN key mapping

From: Jiri Kosina
Date: Wed Feb 16 2022 - 10:50:27 EST


On Tue, 8 Feb 2022, José Expósito wrote:

> Hi everyone,
>
> This patchset adds the missing key mapping for the Magic Keyboard first
> generation and the 2015 models.
>
> Since the first generation model had numlock emulation in place, I
> decided to fix the bug (described in the patch) and keep it in place
> just because it has been there for so long that people might use it.
> Having said that, there is no indication in the keyboard about which
> keys can be used as numbers or how to enable/disable numlock.
> I think that a patch removing APPLE_NUMLOCK_EMULATION might make sense,
> but I didn't want to remove existing functionality without asking :)
>
> Thanks a lot,
> José Expósito
>
> v2: Resolve conflicts

Queued in hid.git#for-5.18/apple. Thanks José,

--
Jiri Kosina
SUSE Labs