Re: [PATCH v2] parport_pc: Also enable driver for PCI systems

From: Christoph Hellwig
Date: Wed Feb 16 2022 - 10:28:58 EST


On Tue, Feb 15, 2022 at 09:11:45AM +0000, Maciej W. Rozycki wrote:
> On Mon, 14 Feb 2022, Christoph Hellwig wrote:
>
> > > ===================================================================
> > > --- linux-macro.orig/arch/arm64/include/asm/Kbuild
> > > +++ linux-macro/arch/arm64/include/asm/Kbuild
> > > @@ -3,6 +3,7 @@ generic-y += early_ioremap.h
> > > generic-y += mcs_spinlock.h
> > > generic-y += qrwlock.h
> > > generic-y += qspinlock.h
> > > +generic-y += parport.h
> >
> > Instead of adding generic-y just ad a mandatory-y in
> > include/asm-generic/Kbuild.
>
> I'm inconvinced. Not all archs want it, 5 don't.

Which is exactly what mandatory-y is for. Provide the asm-generic
version by default, but let architectures override it.