[RFC PATCH] iio: core: provide a default value `label` property

From: Nandor Han
Date: Wed Feb 16 2022 - 08:56:29 EST


The label property is used to correctly identify the same IIO device
over reboots. The implementation requires that a value will be provided
through device-tree. This sometime could requires many changes to
device-trees when multiple devices want to use the label property.
In order to prevent this, we could use the device-tree node
name as default value. The device-tree node name is unique and
also reflects the device which makes it a good choice as default value.
This change is backward compatible since doesn't affect the users that
do configure a label using the device-tree or the ones that are not
using the labels at all.

Use the device-tree node name as a default value for `label` property,
in case there isn't one configured through device-tree.

Signed-off-by: Nandor Han <nandor.han@xxxxxxxxxxx>
---

Notes:
Testing
-------
Using mx6sxsabresd dev board with device-tree:
```
&adc1 {
vref-supply = <&reg_vref_3v3>;
label = "adc1";
status = "okay";
};

&adc2 {
vref-supply = <&reg_vref_3v3>;
status = "okay";
};
```
1. Verify that label property is visible and readable:PASS
> iio:device0 # ls -la label
-r--r--r-- 1 root root 4096 Jan 1 00:00 label
> iio:device0 # cat label
adc1
```
2. Verify that default label property is used for adc2 device: PASS
```
> iio:device1 # cat label
adc@2284000
```

drivers/iio/industrialio-core.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index e1ed44dec2ab..bd26df90ce41 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -1895,6 +1895,7 @@ int __iio_device_register(struct iio_dev *indio_dev, struct module *this_mod)
{
struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
const char *label;
+ const char *node_name;
int ret;

if (!indio_dev->info)
@@ -1906,8 +1907,13 @@ int __iio_device_register(struct iio_dev *indio_dev, struct module *this_mod)
indio_dev->dev.of_node = indio_dev->dev.parent->of_node;

label = of_get_property(indio_dev->dev.of_node, "label", NULL);
- if (label)
+ if (label) {
indio_dev->label = label;
+ } else {
+ node_name = of_node_full_name(indio_dev->dev.of_node);
+ if (node_name)
+ indio_dev->label = node_name;
+ }

ret = iio_check_unique_scan_index(indio_dev);
if (ret < 0)
--
2.34.1