Re: [PATCH v4] x86/cpu: clear SME feature flag when not in use

From: Limonciello, Mario
Date: Wed Feb 16 2022 - 08:42:10 EST


On 2/16/2022 04:33, Borislav Petkov wrote:
On Tue, Feb 15, 2022 at 09:44:46PM -0600, Mario Limonciello wrote:
@@ -607,6 +609,9 @@ static void early_detect_mem_encrypt(struct cpuinfo_x86 *c)
if (IS_ENABLED(CONFIG_X86_32))
goto clear_all;
+ if (!sme_me_mask)
+ setup_clear_cpu_cap(X86_FEATURE_SME);

Why not "goto clear_all;" ?


"clear_all" clears SEV and SEV_ES as well which as pointed out in v2 is incorrect.