Re: [PATCH v2 03/15] staging: r8188eu: remove converted DBG_88E calls from core/rtw_mlme_ext.c

From: Pavel Skripkin
Date: Wed Feb 16 2022 - 04:51:03 EST


Hi Phillip,

On 2/16/22 04:06, Phillip Potter wrote:
Remove all the netdev_dbg/pr_debug calls that were previously converted
from DBG_88E inside core/rtw_mlme_ext.c. Due to the sheer number of
lines, this patch is separated out for ease of review. After some thought,
it makes more sense to just entirely strip all of these calls, so that
debugging code in the driver can be more consistent and useful going
forwards.

Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>

[code snip]

if (pstat->aid > 0) {
- netdev_dbg(padapter->pnetdev, "old AID %d\n", pstat->aid);
} else {

Ok, this one has same issues as 2nd one. I am going to stop reviewing this series for now, because looks like I am missing some context...



With regards,
Pavel Skripkin