Re: [PATCH V6 3/6] mfd: pm8008: Add mfd cell struct to register LDOs

[Satya Priya Kakitapalli (Temp)]

On 2/16/2022 8:28 AM, Guru Das Srinagesh wrote:
> On Tue, Feb 15, 2022 at 02:23:48PM +0530, Satya Priya wrote:
> >   static const struct of_device_id pm8008_match[] = {
> > -	{ .compatible = "qcom,pm8008", },
> > -	{ },
> > +	{ .compatible = "qcom,pm8008", .data = (void *)PM8008_INFRA},
> > +	{ .compatible = "qcom,pm8008-regulators", .data = (void *)PM8008_REGULATORS},
> Typo perhaps: Please set the last element of this array to the sentinel value NULL.
>          {},


Yes, I'll correct this.


> >   };
> > +MODULE_DEVICE_TABLE(of, pm8008_match)
> Missing a semicolon at the end.


Yes, will add it.


Thanks.