Re: [PATCH v2 1/1] iommu/vt-d: Move intel_iommu_ops to header file

[Lu Baolu]

On 2/15/22 5:51 PM, Andy Shevchenko wrote:
> On Tue, Feb 15, 2022 at 09:31:37AM +0800, Lu Baolu wrote:
> > On 2/14/22 9:27 PM, Joerg Roedel wrote:
> > > On Mon, Feb 07, 2022 at 04:12:40PM +0200, Andy Shevchenko wrote:
>
> ...
>
> > > > +extern const struct iommu_ops intel_iommu_ops;
>
> > > The intel_iommu_ops symbol is only used in drivers/iommu/intel, so I
> > > would prefer a header in that directory. But I leave that up to Baolu to
> > > decide.
> >
> > Agreed. I also have a plan to split them out into a internal header.
>
> The above change is hanging for more than a year, can we apply it and then
> you can do a split?

Yeah. This is my plan. The include/linux/intel-iommu.h also keeps other
internal only helpers. It worth a separated cleanup patch.

Best regards,
baolu