Re: [RESEND v13 05/10] ASoC: qcom: Add register definition for codec rddma and wrdma

[Srinivasa Rao Mandadapu]

On 2/15/2022 6:42 AM, Stephen Boyd wrote:
Thanks for your time Stephen!!!
> Quoting Srinivasa Rao Mandadapu (2022-02-14 06:58:23)
> > This patch adds register definitions for codec read dma and write dma
>   git grep "This patch" -- Documentation/process/
Okay. Will remove and reword the commit message.
> > lpass interface.
> >
> > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
> > Co-developed-by: Venkata Prasad Potturu <quic_potturu@xxxxxxxxxxx>
> > Signed-off-by: Venkata Prasad Potturu <quic_potturu@xxxxxxxxxxx>
> > Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > diff --git a/sound/soc/qcom/lpass.h b/sound/soc/qcom/lpass.h
> > index 7cc3763..e059c4a 100644
> > --- a/sound/soc/qcom/lpass.h
> > +++ b/sound/soc/qcom/lpass.h
> > @@ -39,6 +39,29 @@
> >                          return -EINVAL;         \
> >          } while (0)
> >
> > +static inline bool is_cdc_dma_port(int dai_id)
> > +{
> > +       switch (dai_id) {
> > +       case LPASS_CDC_DMA_RX0 ... LPASS_CDC_DMA_RX9:
> > +       case LPASS_CDC_DMA_TX0 ... LPASS_CDC_DMA_TX8:
> > +       case LPASS_CDC_DMA_VA_TX0 ... LPASS_CDC_DMA_VA_TX8:
> > +               return true;
> > +       default:
> Drop case
Okay. will remove it.
> > +               return false;
> > +       }
> return false;
>
> would be shorter.
Okay. will change it.
> > +}
> > +
> > +static inline bool is_rxtx_cdc_dma_port(int dai_id)
> > +{
> > +       switch (dai_id) {
> > +       case LPASS_CDC_DMA_RX0 ... LPASS_CDC_DMA_RX9:
> > +       case LPASS_CDC_DMA_TX0 ... LPASS_CDC_DMA_TX8:
> > +               return true;
> > +       default:
> > +               return false;
> > +       }
> Same.
Okay.
> > +}
> > +
> >   struct lpaif_i2sctl {
> >          struct regmap_field *loopback;
> >          struct regmap_field *spken;