Re: [PATCH v2 2/5] KVM: x86: remove KVM_X86_OP_NULL and mark optional kvm_x86_ops

[Paolo Bonzini]

On 2/15/22 18:08, Sean Christopherson wrote:
> > - * KVM_X86_OP() and KVM_X86_OP_NULL() are used to help generate
> > + * KVM_X86_OP() and KVM_X86_OP_OPTIONAL() are used to help generate
> >    * "static_call()"s. They are also intended for use when defining
> > - * the vmx/svm kvm_x86_ops. KVM_X86_OP() can be used for those
> > - * functions that follow the [svm|vmx]_func_name convention.
> > - * KVM_X86_OP_NULL() can leave a NULL definition for the
> > - * case where there is no definition or a function name that
> > - * doesn't match the typical naming convention is supplied.
> > + * the vmx/svm kvm_x86_ops.
> But assuming your veto of actually using kvm-x86-ops to fill vendor ops isn't
> overriden, they're_not_  "intended for use when defining the vmx/svm kvm_x86_ops."

True, and the original veto was actually how KVM_X86_OP_NULL() became 
unused.

Paolo