Re: [PATCH v3] iio: accel: adxl345: Add ACPI HID table

[Andy Shevchenko]

On Tue, Feb 15, 2022 at 1:30 PM Kai-Heng Feng
<kai.heng.feng@xxxxxxxxxxxxx> wrote:
> On Tue, Feb 15, 2022 at 4:28 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Tue, Feb 15, 2022 at 6:20 AM Kai-Heng Feng
> > <kai.heng.feng@xxxxxxxxxxxxx> wrote:

...

> > > +       { "ADS0345:00", ADXL345 },
> >
> > This is wrong. First of all, on the left side you put the device
> > instance name (which must not be in the ID tables, since the device
> > instance name is "ID + instance number"). Second, the motivation of
> > this is not clear, if the device is enumerated by ACPI, why do you
> > care about board code?
>
> I was uncertain on this at first, but later I saw some drivers use
> this form (*:00) too, so I just followed through.

Those "drivers" are actually so called board files, i.o.w. hard coded
pieces of what firmware(s) missed. That's why they are using device
instance name(s) instead of the device IDs.

-- 
With Best Regards,
Andy Shevchenko